Repository navigation
tests: PollUntil deadline test tolerates a slow runner - #180
Merged
Merged
Conversation
The macOS release build of community.18.1 failed PollUntil.LastAttemptAtTheDeadline: a slow runner overslept the 100 ms interval, so fewer than 3 attempts fit in 250 ms. The test now requires the first attempt and the one at or after the deadline (2), the upper bound and the deadline itself, which the code guarantees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS release build of community.18.1 (run 42716037801) failed
PollUntil.LastAttemptAtTheDeadline: a slow runner overslept the 100 ms interval, so fewer than 3 attempts fit in 250 ms. The test now requires at least 2 attempts (the first, and the one at or after the deadline), keeps the upper bound and the deadline check. Test-only; no code change.🤖 Generated with Claude Code